[show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info #3676
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mlok-nokia
force-pushed
the
show_tech_with_hwdump_and_sys
branch
from
c93af87 to
65214ee
Compare
…w-mgmt info Signed-off-by: mlok <marty.lok@nokia.com>
|
@judyjoseph and @arlakshm This PR modify the show_tech to include BERT info and also the platform specified hw-mgmt-generate_dump.sh. I have verified that. It works fine. Please review it |
| @@ -1582,6 +1619,25 @@ collect_broadcom() { | |||
|
|
|||
| copy_from_masic_docker "syncd" "/var/log/diagrun.log" "/var/log/diagrun.log" | |||
| copy_from_masic_docker "syncd" "/var/log/bcm_diag_post" "/var/log/bcm_diag_post" | |||
|
|
|||
| # run 'hw-management-generate-dump.sh' script and save the result file | |||
| HW_DUMP_FILE=/usr/bin/hw-management-generate-dump.sh | |||
There was a problem hiding this comment.
This PR should also cleanup the duplicate code in vendor specific functions, otherwise it will cause duplicate execution and increase run time.
There was a problem hiding this comment.
ignore, looks like being done only for broadcom.
Should we move it to common code?
The code gets executed only when vendor provide the executable.
There was a problem hiding this comment.
Melanox and Cisco have implemented the function call hw-management-generate-dump.sh under ASIC specified (collect_mellanox() and collect_cisco_8000. For Broadcom ASIC, we just follow the existing implemenation for avoid the duplicated function call.
if [[ "$asic" = "mellanox" ]]; then
collect_mellanox
fi
if [ "$asic" = "broadcom" ]; then
collect_broadcom
fi
if [ "$asic" = "cisco-8000" ]; then
collect_cisco_8000
fi
What I did
Modify the generate_dump to include the BERT data and the platform specified hw-mgmt info
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)